jonhoo / inferno

A Rust port of FlameGraph
Other
1.65k stars 118 forks source link

Support multiple `--skip-after` #231

Closed bsilver8192 closed 2 years ago

bsilver8192 commented 2 years ago

perf is stopping short on some of my backtraces (I think it's related to complex C++ code in the stack), which fragments the relevant functions in the flamegraph. --skip-after works great to avoid this, but I want to do it for multiple functions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #231 (6a8dbdb) into master (4732660) will decrease coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   87.01%   86.85%   -0.16%     
==========================================
  Files          17       17              
  Lines        2379     2396      +17     
==========================================
+ Hits         2070     2081      +11     
- Misses        309      315       +6     
Impacted Files Coverage Δ
src/collapse/perf.rs 97.97% <100.00%> (+0.12%) :arrow_up:
src/flamegraph/svg.rs 76.07% <0.00%> (-1.85%) :arrow_down:
src/flamegraph/mod.rs 86.89% <0.00%> (-1.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4732660...6a8dbdb. Read the comment docs.

bsilver8192 commented 2 years ago

This looks great, and definitely sounds useful! Could you add a test with multiple skip-afters though? Or just update the current one to have multiple filters?

Done. I went with adding a new one to make sure all the branches are covered (I assume that's what codecov is saying? I haven't dug into what numbers it's reporting).