jonhoo / inferno

A Rust port of FlameGraph
Other
1.65k stars 118 forks source link

Identified external dependencies with `js` color palette #234

Closed daniellockyer closed 2 years ago

daniellockyer commented 2 years ago

Hey @jonhoo - ❀️ Inferno πŸ™‚

I've tested this locally with a tool I'm writing for NodeJS and it produces the following:

CleanShot 2022-03-16 at 10 15 20@2x
daniellockyer commented 2 years ago

As a reference for colors, 0x colors external dependencies in purple, and I think it looks good in Inferno too πŸ™‚

CleanShot 2022-03-16 at 10 26 17@2x
codecov[bot] commented 2 years ago

Codecov Report

Merging #234 (0ca49de) into master (06b22f3) will decrease coverage by 0.03%. The diff coverage is 66.66%.

:exclamation: Current head 0ca49de differs from pull request most recent head f7d14c3. Consider uploading reports for the commit f7d14c3 to get more accurate results

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   86.85%   86.82%   -0.04%     
==========================================
  Files          17       17              
  Lines        2396     2398       +2     
==========================================
+ Hits         2081     2082       +1     
- Misses        315      316       +1     
Impacted Files Coverage Ξ”
src/flamegraph/color/palettes.rs 99.09% <66.66%> (-0.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 06b22f3...f7d14c3. Read the comment docs.

jonhoo commented 2 years ago

Hmm, not entirely sure why CI isn't running. I think it's because I need to "approve and run", but that button doesn't appear. Seems to be some kind of GitHub bug. I'm running the test suite locally, and then I'll update the changelog and publish!

jonhoo commented 2 years ago

Released in 0.11.1 :tada: