Urgau commented 2 years ago

This was proposed by @nagisa in https://github.com/jonhoo/inferno/issues/247, I just applied the suggestions and tested that the result was as expected.

I tried the suggestion of dominant-baseline="hanging", but it will need further work to make it useful as applying instead will just increase the size of the CSS without reducing enough in the SVG.

Fixes https://github.com/jonhoo/inferno/issues/247

codecov[bot] commented 2 years ago

Codecov Report

Merging #254 (7385d4f) into master (2f74fe5) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files          18       18           
  Lines        2541     2541           
=======================================
  Hits         2220     2220           
  Misses        321      321

Impacted Files	Coverage Δ
src/flamegraph/svg.rs	`76.33% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f74fe5...7385d4f. Read the comment docs.

jonhoo commented 2 years ago

Thanks!

jonhoo commented 2 years ago

Released in 0.11.7 :tada:

jonhoo / inferno

Use text-anchor instead of hardcoded offsets #254

Codecov Report