jonhoo / inferno

A Rust port of FlameGraph
Other
1.65k stars 118 forks source link

update dependendies (ahash, quick-xml) #258

Closed crepererum closed 1 year ago

crepererum commented 2 years ago

Hey :wave:

We're using your nice crate over at https://github.com/influxdata/influxdb_iox (indirectly via pprof) and I've seen that some of our the dependencies that inferno pulls are slightly outdated and hence get compiled twice. So I've decided to update them. :slightly_smiling_face:

jonhoo commented 1 year ago

Unfortunately, it looks like some of the CI jobs fail :thinking: I'm guessing some of the formatting from quick-xml may have changed.

Separately, I noticed that criterion has also had a new release — would you mind including that in the PR?

crepererum commented 1 year ago

Working on it (probably needs a few iterations because I cannot get the tests to run locally (the perf and dtrace tests fail all the time and I don't really know why).

Update: I found out why my local tests don't pass, git submodules FTW :sweat_smile:

codecov[bot] commented 1 year ago

Codecov Report

Base: 90.33% // Head: 90.29% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (bb01949) compared to base (3ab9716). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #258 +/- ## ========================================== - Coverage 90.33% 90.29% -0.04% ========================================== Files 19 19 Lines 4241 4226 -15 ========================================== - Hits 3831 3816 -15 Misses 410 410 ``` | [Impacted Files](https://codecov.io/gh/jonhoo/inferno/pull/258?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/flamegraph/color/mod.rs](https://codecov.io/gh/jonhoo/inferno/pull/258/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvY29sb3IvbW9kLnJz) | `86.56% <100.00%> (ø)` | | | [src/flamegraph/color/palettes.rs](https://codecov.io/gh/jonhoo/inferno/pull/258/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvY29sb3IvcGFsZXR0ZXMucnM=) | `99.04% <100.00%> (ø)` | | | [src/flamegraph/mod.rs](https://codecov.io/gh/jonhoo/inferno/pull/258/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvbW9kLnJz) | `97.93% <100.00%> (-0.01%)` | :arrow_down: | | [src/flamegraph/svg.rs](https://codecov.io/gh/jonhoo/inferno/pull/258/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvc3ZnLnJz) | `97.75% <100.00%> (-0.13%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jonhoo commented 1 year ago

Looks like we have a couple of CI failures:

crepererum commented 1 year ago

This is now solely blocked by the quick-xml release.

jonhoo commented 1 year ago

We should also do a bump of clap to major version 4, but I suppose it's no rush (and can be done in a separate PR).

crepererum commented 1 year ago

Updated to quick-xml 0.26 -- which fixes the MSRV. Let's do clap in another PR, also because this would mean that we compile two version of clap (at least for testing) because criterion still uses V3.

jonhoo commented 1 year ago

Ah, forgot the changelog! Would you mind updating that too?

crepererum commented 1 year ago

Ah, forgot the changelog! Would you mind updating that too?

273.