Closed itamarst closed 2 years ago
Base: 90.33% // Head: 90.33% // No change to project coverage :thumbsup:
Coverage data is based on head (
604c7fe
) compared to base (9676e33
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
See attached files to get a sense of the impact, specifically you should resize the window and notice how responsive refreshes are. result.zip
Added zoom()
support too, so now the refresh on startup is faster.
result.zip
Given this only addresses monospace fonts, perhaps the default font should be monospace for now?
I will update changelog once you decide whether you want to change to monospace by default or not.
Yeah, looks reasonable to me — let's update the default!
Released as 0.11.12 :tada:
This addresses #256 partially; variable-width fonts aren't addressed.
By having two passes, one for reading attributes and one for writing attributes, we avoid refreshing the screen a bazillion times, as recommended by https://web.dev/avoid-large-complex-layouts-and-layout-thrashing/.
I tested this by rendering the input file attached in one of the comments on #256 and resizing the window, in both Chrome and Firefox, and with both variations of text truncation. On my very fast desktop, with a monospace font the resize is in real-time, and with variable-width font there is a noticeable pause before refresh happens.
Before merging I should probably at least: