Closed str4d closed 2 years ago
Looks like this was caused by https://github.com/jonhoo/inferno/commit/b8f92605ee2897a3433dd578d9c1a7a6417bd2b0 which reduced the public API surface. Sadly blanket trait impls on public traits are themselves public, regardless of the visibility of the bounds.
The solution here (as described in https://github.com/rust-lang/rust/issues/34537 among other places) is to treat CollapsePrivate
as a sealed trait, where it is public but in a private module (and thus cannot be implemented by downstream library users because it cannot be named). It looks like inferno::collapse::common
is crate-private, so reverting the s/pub/pub(crate)
should be sufficient to resolve this issue.
We use
pprof
for benchmark profiling, which depends oninferno
. The most recent update caused this failure in our CI, whileinferno 0.11.7
compiles fine: