str4d commented 2 years ago

It needs to be in the public API due to the blanket implementation of Collapse for T: CollapsePrivate. The inferno::collapse::common module is crate-private, ensuring that CollapsePrivate and Occurrences cannot be named by downstream library users.

Closes jonhoo/inferno#264.

codecov[bot] commented 2 years ago

Codecov Report

Base: 90.21% // Head: 90.21% // No change to project coverage :thumbsup:

Coverage data is based on head (710584b) compared to base (899e42f). Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #265 +/- ## ======================================= Coverage 90.21% 90.21% ======================================= Files 19 19 Lines 4179 4179 ======================================= Hits 3770 3770 Misses 409 409 ``` | [Impacted Files](https://codecov.io/gh/jonhoo/inferno/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/collapse/common.rs](https://codecov.io/gh/jonhoo/inferno/pull/265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2NvbGxhcHNlL2NvbW1vbi5ycw==) | `66.66% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jonhoo commented 2 years ago

Released as 0.11.9 :tada:

jonhoo / inferno

Make the sealed `CollapsePrivate` trait public again #265

Codecov Report