jonhoo / inferno

A Rust port of FlameGraph
Other
1.65k stars 118 forks source link

Upgrade to version 4 of clap #267

Closed jonhoo closed 1 year ago

jonhoo commented 1 year ago

Replaces #266

This increases MSRV to 1.60.0 (because of clap) when the cli feature is enabled.

djc commented 1 year ago

Another reason to adopt 1.60 (or 1.59) might be to get rid of the num_cpus dependency in favor of std::thread::available_parallelism().

codecov[bot] commented 1 year ago

Codecov Report

Base: 91.11% // Head: 91.14% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (dab523b) compared to base (044e3ab). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #267 +/- ## ========================================== + Coverage 91.11% 91.14% +0.03% ========================================== Files 19 19 Lines 4219 4236 +17 ========================================== + Hits 3844 3861 +17 Misses 375 375 ``` | [Impacted Files](https://codecov.io/gh/jonhoo/inferno/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/flamegraph/color/mod.rs](https://codecov.io/gh/jonhoo/inferno/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvY29sb3IvbW9kLnJz) | `87.39% <ø> (ø)` | | | [src/flamegraph/mod.rs](https://codecov.io/gh/jonhoo/inferno/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvbW9kLnJz) | `98.22% <100.00%> (+0.06%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jonhoo commented 1 year ago

Yep, good call-out. I'll merge this and then land that and a fix to #278 separately.

jonhoo commented 1 year ago

Done in https://github.com/jonhoo/inferno/pull/279

jonhoo commented 1 year ago

Released in 0.11.15 :tada: