jonhoo / inferno

A Rust port of FlameGraph
Other
1.65k stars 118 forks source link

Upgrade num-format to 0.4.3 and criterion to 0.4 #269

Closed bcmyers closed 1 year ago

bcmyers commented 1 year ago

I neglected to maintain num-format (a dependency of inferno) for a long time (years, basically); so it was sorely out-of-date. I intend to start maintaining it going forward.

I just published an updated version of num-format to crates.io. It's public API remains the same, but under the hood the following dependencies have been updated...

This diff ensures inferno is using at least num-format 0.4.3.

codecov[bot] commented 1 year ago

Codecov Report

Base: 90.21% // Head: 90.21% // No change to project coverage :thumbsup:

Coverage data is based on head (02fca08) compared to base (2837bab). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #269 +/- ## ======================================= Coverage 90.21% 90.21% ======================================= Files 19 19 Lines 4179 4179 ======================================= Hits 3770 3770 Misses 409 409 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jonhoo commented 1 year ago

Ah, so that's where the old itoa came from! I think you may also have to run something like cargo tree and git add the resulting modifications to the lockfile 👍

jonhoo commented 1 year ago

Hmm, it looks like you've somehow pulled in a bunch of changes from the main branch as well?

bcmyers commented 1 year ago

Just fixed.

bcmyers commented 1 year ago

oh, oops. gotta push lockfile change too... One second.

bcmyers commented 1 year ago

Let me try one more time to fix the lockfile...

bcmyers commented 1 year ago

Looks like criterion is now the culprit for the fact that itoa 0.4 is sticking around...

├── criterion v0.3.6
│   ├── atty v0.2.14 (*)
│   ├── cast v0.3.0
│   ├── clap v2.34.0
│   │   ├── bitflags v1.3.2
│   │   ├── textwrap v0.11.0
│   │   │   └── unicode-width v0.1.10
│   │   └── unicode-width v0.1.10
│   ├── criterion-plot v0.4.5
│   │   ├── cast v0.3.0
│   │   └── itertools v0.10.4 (*)
│   ├── csv v1.1.6
│   │   ├── bstr v0.2.17 (*)
│   │   ├── csv-core v0.1.10
│   │   │   └── memchr v2.5.0
│   │   ├── itoa v0.4.8
│   │   ├── ryu v1.0.11
│   │   └── serde v1.0.144
bcmyers commented 1 year ago

Perhaps we should upgrade criterion in a separate PR?

bcmyers commented 1 year ago

Nevermind. Upgrading criterion to 0.4 was easy. Now we've completely eliminated itoa 0.4

jonhoo commented 1 year ago

Released in 0.11.10 :tada: