Closed bcmyers closed 1 year ago
Base: 90.21% // Head: 90.21% // No change to project coverage :thumbsup:
Coverage data is based on head (
02fca08
) compared to base (2837bab
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ah, so that's where the old itoa came from! I think you may also have to run something like cargo tree
and git add
the resulting modifications to the lockfile 👍
Hmm, it looks like you've somehow pulled in a bunch of changes from the main branch as well?
Just fixed.
oh, oops. gotta push lockfile change too... One second.
Let me try one more time to fix the lockfile...
Looks like criterion is now the culprit for the fact that itoa 0.4 is sticking around...
├── criterion v0.3.6
│ ├── atty v0.2.14 (*)
│ ├── cast v0.3.0
│ ├── clap v2.34.0
│ │ ├── bitflags v1.3.2
│ │ ├── textwrap v0.11.0
│ │ │ └── unicode-width v0.1.10
│ │ └── unicode-width v0.1.10
│ ├── criterion-plot v0.4.5
│ │ ├── cast v0.3.0
│ │ └── itertools v0.10.4 (*)
│ ├── csv v1.1.6
│ │ ├── bstr v0.2.17 (*)
│ │ ├── csv-core v0.1.10
│ │ │ └── memchr v2.5.0
│ │ ├── itoa v0.4.8
│ │ ├── ryu v1.0.11
│ │ └── serde v1.0.144
Perhaps we should upgrade criterion in a separate PR?
Nevermind. Upgrading criterion to 0.4 was easy. Now we've completely eliminated itoa 0.4
Released in 0.11.10 :tada:
I neglected to maintain
num-format
(a dependency ofinferno
) for a long time (years, basically); so it was sorely out-of-date. I intend to start maintaining it going forward.I just published an updated version of
num-format
to crates.io. It's public API remains the same, but under the hood the following dependencies have been updated...This diff ensures
inferno
is using at leastnum-format
0.4.3.