codecov[bot]
commented
1 year ago Codecov Report
Base: 91.17% // Head: 91.15% // Decreases project coverage by -0.02% :warning:
Coverage data is based on head (
7c62ec3) compared to base (ace888c). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #282 +/- ## ========================================== - Coverage 91.17% 91.15% -0.02% ========================================== Files 19 19 Lines 4237 4242 +5 ========================================== + Hits 3863 3867 +4 - Misses 374 375 +1 ``` | [Impacted Files](https://codecov.io/gh/jonhoo/inferno/pull/282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/flamegraph/merge.rs](https://codecov.io/gh/jonhoo/inferno/pull/282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvbWVyZ2UucnM=) | `95.31% <100.00%> (ø)` | | | [src/flamegraph/mod.rs](https://codecov.io/gh/jonhoo/inferno/pull/282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2ZsYW1lZ3JhcGgvbW9kLnJz) | `98.23% <100.00%> (+0.01%)` | :arrow_up: | | [src/collapse/common.rs](https://codecov.io/gh/jonhoo/inferno/pull/282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2NvbGxhcHNlL2NvbW1vbi5ycw==) | `66.73% <0.00%> (-0.22%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
jonhoo
Note that since we have
pubfunctions that returnquick_xmltypes, this would be a breaking change.Interestingly enough, we only expose
quick_xmlin the form ofquick_xml::Resultas far as I can tell. Specifically, we're using its error type, which feels like something we can avoid to mitigate this kind of "transitive bump" in the future. In particular, I think we could reasonable start using an opaque error type for these methods instead.Marking this as a draft so we don't merge it without intending to do a major release.