jonhoo / inferno

A Rust port of FlameGraph
Other
1.64k stars 117 forks source link

`xctrace` support #286

Open ldm0 opened 1 year ago

ldm0 commented 1 year ago

Basically working. Required to be done:

Fixes #246

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 84.70% of modified lines.

Files Changed Coverage
src/collapse/mod.rs ø
src/collapse/xctrace.rs 84.58%
src/collapse/guess.rs 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

kraktus commented 1 year ago

Hey, I was going to start working on integrating this only to see the work was already done! Thanks @ldm0!

I can help add the documentation if needed. Also not sure if this feature need to be tied to the quick-xml update?

ldm0 commented 1 year ago

I can help add the documentation if needed. Also not sure if this feature need to be tied to the quick-xml update?

Thanks! I've written some documentation already, will submit it tomorrow. I think introducing multiple versions of the same dependency is bad(in terms of artifact size and complexity), so I'm waiting for the quick-xml update.

BTW, I've forked flamegraph with this inferno branch and you can try it: cargo install --git https://github.com/ldm0/flamegraph --branch xctrace, I replaced the default tracer(dtrace) with xctrace on macOS. (Make sure you get an XCode>=14.3 though)