jonhoo / inferno

A Rust port of FlameGraph
Other
1.71k stars 125 forks source link

Bump MSRV to match clap dependency #301

Closed rukai closed 1 week ago

rukai commented 1 year ago

Since clap 4.4 bumped its MSRV to 1.70 inferno no longer builds on 1.64 and needs minimum 1.70 This PR:

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.01%. Comparing base (5d88bc3) to head (8af0614). Report is 44 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #301 +/- ## ======================================= Coverage 91.01% 91.01% ======================================= Files 19 19 Lines 4385 4385 ======================================= Hits 3991 3991 Misses 394 394 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

rukai commented 1 year ago

Understandable, I'll mark this as draft so it's around when it's needed.

jonhoo commented 1 week ago

Given I'm about to do a breaking release anyway in https://github.com/jonhoo/inferno/pull/335, I'll land this as part of it! May have to do some cherry-picking, but hey, it did end up useful in the end :D

jonhoo commented 1 week ago

Merged in https://github.com/jonhoo/inferno/pull/336