jonhoo / inferno

A Rust port of FlameGraph
Other
1.64k stars 117 forks source link

Bump MSRV to match clap dependency #301

Open rukai opened 1 year ago

rukai commented 1 year ago

Since clap 4.4 bumped its MSRV to 1.70 inferno no longer builds on 1.64 and needs minimum 1.70 This PR:

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (5d88bc3) 91.01% compared to head (8af0614) 91.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #301 +/- ## ======================================= Coverage 91.01% 91.01% ======================================= Files 19 19 Lines 4385 4385 ======================================= Hits 3991 3991 Misses 394 394 ``` | [Files Changed](https://app.codecov.io/gh/jonhoo/inferno/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/collapse/mod.rs](https://app.codecov.io/gh/jonhoo/inferno/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2NvbGxhcHNlL21vZC5ycw==) | `96.96% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rukai commented 1 year ago

Understandable, I'll mark this as draft so it's around when it's needed.