search

jonhoo / inferno

A Rust port of FlameGraph
Other
1.64k stars 117 forks source link

Fix `cargo clippy --all-targets` lints #302

Closed rukai closed 11 months ago

rukai commented 1 year ago

clippy::disallowed_names was complaining about variables named foo in a test, it seemed a silly thing to complain about so I just disabled it instead. Happy to instead rename those variables if desired.

The rest all seem uncontroversial to me.

jonhoo commented 1 year ago

Also, yes, definitely the right call to disable that lint. Feels like a bug in the lint really to be disallowing these names in test code...

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/flamegraph/svg.rs ø
src/differential/mod.rs 100.00%
src/flamegraph/color/mod.rs 100.00%
src/flamegraph/color/palettes.rs 100.00%
src/flamegraph/mod.rs 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

rukai commented 1 year ago

I addressed those two issues