jonhoo / inferno

A Rust port of FlameGraph
Other
1.65k stars 118 forks source link

Align FlameGraph color scheme to match original Perl script output #327

Open jamel opened 1 month ago

jamel commented 1 month ago

I'm developing an internal tool to capture performance data and generate flame graph SVGs. This tool aims to replace a set of scripts with a single executable featuring user-friendly sub-commands. The inferno library is working great, and I appreciate your effort in creating it! However, the coloring scheme of the produced SVGs differs from the original flamegraph.pl script, which has led to complaints from colleagues accustomed to the previous color scheme.

What do you think about one of this?

jonhoo commented 1 month ago

I'm interested to hear in what way it diverges — in general, this was a pretty direct port, including the color selection. It may however be that we've iterated further beyond the original flamegraph since then. Could you post some images of the differences?

Overall I'd be happy to include a palette that replicates the original :+1: