search

jonhoo / left-right

A lock-free, read-optimized, concurrency primitive.
Apache License 2.0
1.94k stars 94 forks source link

Upgrade to Bytes 0.0.6 #72

Closed benbromhead closed 3 years ago

benbromhead commented 3 years ago

Quick update for evmap to use latest version of bytes

cargo test makes this look simple enough

This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (cd55c78) into master (d4c12b8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          12       12           
  Lines        1234     1234           
=======================================
  Hits         1025     1025           
  Misses        209      209

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4c12b8...cd55c78. Read the comment docs.

jonhoo commented 3 years ago

Thank you! Sadly, this is a breaking change, so I'll have to hold off on merging this until the next major release. I think that'll come in not too long though :)

benbromhead commented 3 years ago

All good I'd just left the version as version = "11.0.0-alpha.1" based on master, but yeah its def a major version change.

I ended up moving my other deps back to bytes=0.5 anyway (:

jonhoo commented 3 years ago

Heads up that this will be fixed by #83, since it no longer uses the ShallowCopy trait, and thus we don't need to implement anything for Bytes at all!