search

jonhoo / left-right

A lock-free, read-optimized, concurrency primitive.
Apache License 2.0
1.95k stars 94 forks source link

Change DropBehavior to have associated const instead of function. #87

Closed ShaneEverittM closed 3 years ago

ShaneEverittM commented 3 years ago

This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #87 (1f651e2) into master (9821e18) will increase coverage by 10.17%. The diff coverage is 100.00%.

Impacted Files Coverage Δ
left-right/src/aliasing.rs 44.44% <100.00%> (+44.44%) :arrow_up:
left-right/src/lib.rs 38.46% <0.00%> (+38.46%) :arrow_up:
left-right/src/read.rs 63.04% <0.00%> (+63.04%) :arrow_up:
left-right/src/read/guard.rs 71.42% <0.00%> (+71.42%) :arrow_up:
left-right/src/write.rs 75.53% <0.00%> (+75.53%) :arrow_up:
Eh2406 commented 3 years ago

cc #85

jonhoo commented 3 years ago

Ah, excellent, thank you! This is going to require a breaking change for left-right, so could you please update evmap to have a path dependency on left-right as well, and then fix the resulting error in evmap (specifically its impl DropBehavior blocks also have to change).

ShaneEverittM commented 3 years ago

Cool! First PR ever!

jonhoo commented 3 years ago

Published in left-right 0.11 and evmap 11.0.0-alpha.5 :tada: