search

jonhoo / left-right

A lock-free, read-optimized, concurrency primitive.
Apache License 2.0
1.94k stars 94 forks source link

add WriteHandle::take #94

Closed pYtoner closed 3 years ago

pYtoner commented 3 years ago

This change is Reviewable

pYtoner commented 3 years ago

There might be a better way to signal to the drop that it needs to not do its thing. But a bool might be worth the clearness.

pYtoner commented 3 years ago

I am also not sure how the documentation should mention that the drop second should be called if it is needed or if it should at all.

codecov[bot] commented 3 years ago

Codecov Report

Merging #94 (c3d7188) into master (a8f42a8) will decrease coverage by 3.00%. The diff coverage is 6.25%.

Impacted Files Coverage Δ
src/write.rs 78.97% <6.25%> (-7.28%) :arrow_down: