search

jonhoo / rust-ci-conf

Collection of CI configuration files for Rust projects
287 stars 60 forks source link

Use rust-toolchain component instead of the archived clippy-check action #18

Closed just1602 closed 9 months ago

just1602 commented 9 months ago

Hello,

The actions-rs/clippy-check action was still used even if the repo is archived since a couple of months, and it was giving me warnings on a project, so I deciced to remove it and use clippy from the rust-toolchain action since you installed it on the line above.

jonhoo commented 9 months ago

Hi there!

The downside of just invoking clippy directly is that issues clippy identifies no longer show up as "GitHub Checks" (see the Checks announcement for an example), making them more or less invisible (since Clippy usually just produces warnings, not errors). We could pass -D warnings, but that'd also be problematic since it would cause the CI job to fail basically whenever there's a new Rust release (at least for any sizeable project).

I don't actually know of a replacement for actions-rs/clippy-check. That is, something that integrates clippy with GitHub Checks. If you can find one, I'd be very much happy to swap it out given it is unmaintained as you say!

just1602 commented 9 months ago

Oh, I wasn't aware of this missing behaviour. I'll try to find something else and open a new PR if I find something that integrate with the check system correctly. :)