search

jonhoo / rust-imap

IMAP client library for Rust
Apache License 2.0
477 stars 80 forks source link

Un-export some exposed `parse()` functions #251

Closed bitfehler closed 1 year ago

bitfehler commented 1 year ago

As @jonhoo pointed out here, the various types' parse() functions should not be exported. Some are, though. The 3.0 release is probably a good time to fix that.

Note: some types (e.g. Mailbox, Deleted) didn't have their parse() function exposed, so I think it's pretty safe to assume that nobody built anything seriously using these.

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #251 (64e7b4a) into main (acb5d98) will not change coverage. The diff coverage is 100.0%.

Additional details and impacted files | [Impacted Files](https://codecov.io/gh/jonhoo/rust-imap/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/types/acls.rs](https://codecov.io/gh/jonhoo/rust-imap/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2FjbHMucnM=) | `96.5% <100.0%> (ø)` | | | [src/types/capabilities.rs](https://codecov.io/gh/jonhoo/rust-imap/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2NhcGFiaWxpdGllcy5ycw==) | `55.8% <100.0%> (ø)` | | | [src/types/fetch.rs](https://codecov.io/gh/jonhoo/rust-imap/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2ZldGNoLnJz) | `60.4% <100.0%> (ø)` | | | [src/types/name.rs](https://codecov.io/gh/jonhoo/rust-imap/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL25hbWUucnM=) | `68.9% <100.0%> (ø)` | |