search

jonhoo / rust-imap

IMAP client library for Rust
Apache License 2.0
477 stars 80 forks source link

Implementing capability caching #255

Open dequbed opened 1 year ago

dequbed commented 1 year ago

Based on this comment by @jonhoo on #243 this PR adds the ability for Client and Session to cache returned Capabilities.

Future work should try to parse (the optionally sent) Capabilities from untagged responses to EHLO, STARTTLS, and AUTHENTICATE automatically; if none are sent they should be automatically queried.

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #255 (04f5c9e) into main (41c5597) will decrease coverage by 0.8%. The diff coverage is 33.8%.

Additional details and impacted files | [Impacted Files](https://codecov.io/gh/jonhoo/rust-imap/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/client.rs](https://codecov.io/gh/jonhoo/rust-imap/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2NsaWVudC5ycw==) | `91.5% <26.0%> (-1.7%)` | :arrow_down: | | [src/types/capabilities.rs](https://codecov.io/gh/jonhoo/rust-imap/pull/255?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2NhcGFiaWxpdGllcy5ycw==) | `55.9% <56.2%> (+0.1%)` | :arrow_up: |
jonhoo commented 1 year ago

I think the last bit here now is https://github.com/jonhoo/rust-imap/pull/255#discussion_r1125573266

bogthe commented 5 months ago

Hi @dequbed, I really liked that you were adding support for SASL in #243. Do you have any plans to update this PR? If you're short on time, I would be happy to help getting this (and that one) merged!