search

jonhoo / rust-imap

IMAP client library for Rust
Apache License 2.0
477 stars 80 forks source link

Replace mpsc::{Sender,Receiver} by VecDeque #260

Open soywod opened 1 year ago

soywod commented 1 year ago

Fixes #254.

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #260 (f0a6515) into main (94418d8) will increase coverage by 0.0%. The diff coverage is 92.7%.

Additional details and impacted files | [Impacted Files](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/client.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2NsaWVudC5ycw==) | `93.1% <85.1%> (-0.1%)` | :arrow_down: | | [src/parse.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3BhcnNlLnJz) | `90.4% <93.9%> (+0.4%)` | :arrow_up: | | [src/extensions/list\_status.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2V4dGVuc2lvbnMvbGlzdF9zdGF0dXMucnM=) | `88.0% <100.0%> (ø)` | | | [src/extensions/metadata.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2V4dGVuc2lvbnMvbWV0YWRhdGEucnM=) | `92.5% <100.0%> (ø)` | | | [src/types/acls.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2FjbHMucnM=) | `96.5% <100.0%> (ø)` | | | [src/types/capabilities.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2NhcGFiaWxpdGllcy5ycw==) | `55.8% <100.0%> (ø)` | | | [src/types/fetch.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL2ZldGNoLnJz) | `65.1% <100.0%> (ø)` | | | [src/types/name.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL25hbWUucnM=) | `68.9% <100.0%> (ø)` | | | [src/types/quota.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL3R5cGVzL3F1b3RhLnJz) | `87.6% <100.0%> (ø)` | |
bogthe commented 5 months ago

Hi @soywod I really like this PR and it also looks super close to being finished. Is there anyway I can help get this merged?

soywod commented 5 months ago

I forgot about this PR as it did not fix my initial issue. I can take a look back during this week and see if I can complete it.