search

jonhoo / rust-imap

IMAP client library for Rust
Apache License 2.0
477 stars 80 forks source link

Update greenmail docker image version in README. #281

Closed ath closed 6 months ago

ath commented 7 months ago

Hint to use the newer (stable) 1.6.15 version. All tests still pass.

This change is Reviewable

jonhoo commented 7 months ago

Good idea! Would you mind also updating the images used in CI (under .github/workflows/)?

ath commented 7 months ago

Good idea! Would you mind also updating the images used in CI (under .github/workflows/)?

Absolutely, I’ve added another commit. The workflow ran okay and passed all tests, with the exception of coverage (codecov.io): https://github.com/ath/rust-imap/actions

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a2d9c22) 86.1% compared to head (cd7c545) 86.1%.

Additional details and impacted files [see 3 files with indirect coverage changes](https://app.codecov.io/gh/jonhoo/rust-imap/pull/281/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)
jonhoo commented 7 months ago

Hmm, looks like the greenmail CI job is failing?

ath commented 7 months ago

Hmm, looks like the greenmail CI job is failing?

Yes, that is a bit surprising. This is my run on GH Actions: https://github.com/ath/rust-imap/actions/runs/7863986957 And here our PR run: https://github.com/jonhoo/rust-imap/actions/runs/7863987060

I understodd that my coverage test on codecov failed, as I have no account there and didn’t provide an API key. You otoh likely configured this, so the PR run was okay with it.

But the greenmail tests ran without any troubles, a few minutes before it was started here in this repo.

ath commented 7 months ago

I looked at the two failed tests. In the first case all tests passed. Only at the end the output says that the "operation was cancelled".

The second step failed though in the test tls_force with a network problem, the connection was lost. Given that it ran on Github in my repo, and given that it runs without problems on my local machine I assume that this might be connected with GH Actions. Can you trigger the build & tests again and we see if this runs through?

Locally I did this: docker run -d -p 3025:3025 -p 3110:3110 -p 3143:3143 -p 3465:3465 -p 3993:3993 -p 3995:3995 -e GREENMAIL_OPTS="-Dgreenmail.setup.test.all -Dgreenmail.hostname=0.0.0.0 -Dgreenmail.auth.disabled -Dgreenmail.verbose" greenmail/standalone:1.6.15

and then cargo test --locked --all-targets

Works perfectly.

jonhoo commented 6 months ago

Interesting — looks like they both passed after I retried them, so we're all good! Thanks :tada: