search

jonhoo / rust-imap

IMAP client library for Rust
Apache License 2.0
477 stars 80 forks source link

Refactor tag assertion to FatalError check & Fix unexpected increase of tag (fork) #284

Closed soywod closed 5 months ago

soywod commented 5 months ago

This is just a fork of https://github.com/jonhoo/rust-imap/pull/231 so it can be finished and merged.

This change is Reviewable

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 85.6%. Comparing base (345bd64) to head (0a2fed0).

Additional details and impacted files | [Files](https://app.codecov.io/gh/jonhoo/rust-imap/pull/284?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset) | Coverage Δ | | |---|---|---| | [src/error.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2Vycm9yLnJz) | `21.4% <0.0%> (-3.1%)` | :arrow_down: | | [src/client.rs](https://app.codecov.io/gh/jonhoo/rust-imap/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset#diff-c3JjL2NsaWVudC5ycw==) | `92.8% <40.0%> (-0.8%)` | :arrow_down: | ... and [16 files with indirect coverage changes](https://app.codecov.io/gh/jonhoo/rust-imap/pull/284/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jon+Gjengset)
soywod commented 5 months ago

One test fails but it is not related to this PR.

soywod commented 5 months ago

Let's get this merged

Awesome, thank you! Do you think it could be possible to release a new alpha version? I need this fix to release a new version of mine.

jonhoo commented 5 months ago

Yep, it's coming shortly! I'm preparing it over here: https://github.com/jonhoo/rust-imap/pull/285

The specific doc changes I made are these: https://github.com/jonhoo/rust-imap/pull/285/commits/ed433ec5745a3dfb1aaecc22bbbe5d834d5c33dd

jonhoo commented 5 months ago

Published as 3.0.0-alpha.13 :tada: