search

joni2back / angular-filemanager

JavaScript File Manager Material Design Folder Explorer Navigator Browser Manager in AngularJS with CSS3 Responsive (with FTP in PHP / Java / Node)
https://joni2back.github.io/angular-filemanager/
MIT License
1.76k stars 575 forks source link

Change edit button to save, as its confusing to label it edit, as edi… #332

Closed pellcorp closed 6 years ago

pellcorp commented 6 years ago

…t is the verb to open the dialog, and save should be the verb to update the file.

I don't have a translation for non english so I set the save button text to the same as Edit for all of those, so its not a regression of UI behaviour for other languages.

joni2back commented 6 years ago

Hi @pellcorp I see some translations are wrong, if we are moving to save == save, there are some languages that keeps the "edit/modify" word.

Example in some langs:

save: 'Editar',
save: 'Éditer',
save: 'Modifica',
pellcorp commented 6 years ago

Yep I don't know the translations for the other langs. But it's not a regression for them as they are already equivalent of edit. Figured you or whomever did the original translations might be able to provide the Save language

joni2back commented 6 years ago

Thanks @pellcorp !