Updated README.md with install steps

[thepante]

I propose this way of showing the installation instructions. It's more self-explained.
Also added a notice that it can be set as default in the browser.

[marathone]

Nice! I think instructions on how to get it working in Kodi MediaPlayer would be good too. I haven't been able to figure out how to launch the engine from Kodi so acestream links will play in that environment. Thanks.

On Thu, Oct 4, 2018 at 7:57 PM thepante notifications@github.com wrote:

I propose this way of showing the installation instructions. It's more self-explained. Also added a notice that it can be set as default in the browser.

You can view, comment on, or merge this pull request online at:

https://github.com/jonian/acestream-launcher/pull/31 Commit Summary

• Steps for install it
• Update README.md
• Update README.md
• Update README.md

File Changes

• M README.md https://github.com/jonian/acestream-launcher/pull/31/files#diff-0 (15)

Patch Links:

• https://github.com/jonian/acestream-launcher/pull/31.patch
• https://github.com/jonian/acestream-launcher/pull/31.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jonian/acestream-launcher/pull/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AUF9bcRrB7c7Wh57M-s0SkTEb34wPR98ks5uhqBhgaJpZM4XJVdI .

-- "It is through science that we prove, but through intuition that we discover."

• Henri Poincare

[jonian]

Hi @thepante. Thanks for the PR. I think that acestream-engine needs more instructions to install https://askubuntu.com/questions/763364/how-to-watch-acestream-sopcast-ubuntu-16-04-lts#765407, since it is not in the official repos (correct me if I'm wrong).

[thepante]

You are right @jonian, my bad; I already had all configured up (but outdated versions), I didn't check that part.

I removed all about acestream content from my system to redo it. Seems that method for install the engine is not working anymore.

---

So here is what I got. (I'm under ubuntu 18.04) :

I already had, but in this step it would be:

sudo apt-get install python libnotify

Acestream engine:

wget "http://dl.acestream.org/linux/acestream_3.1.16_ubuntu_16.04_x86_64.tar.gz"
tar zxvf acestream_3.1.16_ubuntu_16.04_x86_64.tar.gz
mv acestream_3.1.16_ubuntu_16.04_x86_64 /opt/acestream

Then acestream-launcher:

git clone https://github.com/jonian/acestream-launcher.git
cd acestream-launcher
sudo ./install.sh

And here had to edit the install.sh because of line 9 - I edited lines 9 and 10:

  cp "*.py" "/opt/$pkgname"
  cp "$pkgname.desktop" "/opt/$pkgname/$pkgname.desktop"

to ↓

  cp *.py /opt/$pkgname
  cp $pkgname.desktop /opt/$pkgname/$pkgname.desktop

Reason is that * is inside " ", so the script attempts to copy a file named *.py that doesn't exists.
Line 10 I edited to have a visual reference that the script worked without those " " by checking the .desktop in its new path.

After that, I get all installed. Then test:

acestream-launcher acestream://b18057511beff1783c090985d52687c7de6a684e

Output, error:

Acestream engine not found in provided path!

Then, tested:

acestream-launcher -e "/opt/acestream/start-engine" acestream://b18057511beff1783c090985d52687c7de6a684e

reference
Output:

Cannot connect to Acestream engine!  
Exiting...

Well, no luck only installing acestream engine without the need of also installing its player. So I tried with the snap:

sudo snap install acestreamplayer

Then use it with:

acestream-launcher -e "acestreamplayer.engine --client-console" acestream://b18057511beff1783c090985d52687c7de6a684e

Working great.

Conclusion

After removing all acestream & launcher traces from my system, the only way I can get it working:

1. Install acestream snap
2. Clone acestream-launcher repo
3. Edit install.sh deleting the " " from cp commands
4. Install acestream-launcher

5. Execute acestream-launcher with -e "acestreamplayer.engine --client-console"

   :tada:

---

Edit: I would edit and update this pull request with updated readme.md proposition (even that issue with the install.sh), but don't want to do a mess. I'm just learning how this all git works

[jonian]

@thepante Thanks for all the info and the effort you put into this. I appreciate it.

Regarding the installation from the .tar.gz package, on the reference you provided (acestream wiki), it says at the bottom:

To make this work you need to create /usr/bin/acestreamengine shell script which points to the folder where you have installed engine in. For example, if you have installed engine in /opt/acestream then the script will be:

#!/bin/bash
ROOT=/opt/acestream
LD_LIBRARY_PATH=${ROOT}/lib ${ROOT}/acestreamengine --lib-path ${ROOT} $@

This is what I do on the acestream-engine package for Arch Linux https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=acestream-engine.

Edit: I would edit and update this pull request with updated readme.md proposition (even that issue with the install.sh), but don't want to do a mess. I'm just learning how this all git works

If you want you can go ahead. Messing things is what helps you learn faster!

---

Edit: I added support for configuration file. You can use it to set acestreamplayer.engine --client-console as the default engine command.

[thepante]

@jonian so convenient to have that config file now, great!

Tried that about the script pointing out the correct path, but for me didn't worked. Later I'll keep checking what I had missing.

---

I updated that, just the edit was needed, cool that its simple :laughing: . But that about resolving conflicts; I do not understand, later I'll read about it.

[jonian]

I resolved the conflicts. Is it ready to merge or do you want to add anything else?

[thepante]

:+1: great, that's it. Thanks