search

jonjamz / blaze-forms

Dead easy reactive forms with validation (Meteor).
https://atmospherejs.com/templates/forms
MIT License
113 stars 11 forks source link

Package depending on deprecated aldeed:simple-schema #108

Open danielparas opened 7 years ago

danielparas commented 7 years ago

Hey @jonjamz! as usual thanks for this package - it's been very useful!

I just updated aldeed:collection2 and it was quite a major update. Part of which involves the removal and deprecation of the aldeed:simple-schema package. Please see below, note from the package author:

Verify that aldeed:simple-schema is not listed in your .meteor/.versions file. If it is, you likely depend on some other package that has an explicit dependency on the Meteor aldeed:simple-schema package. This could cause problems or unexpected behavior. Work with that package author to get an updated version that does not explicitly depend on the aldeed:simple-schema package.

From: https://github.com/aldeed/meteor-collection2

Is it possible to remove the aldeed:simple-schema dependency?

Thanks Daniel

jonjamz commented 7 years ago

Hi Daniel,

I will look into this today.

Jon

On Aug 10, 2017, at 4:50 AM, danielparas notifications@github.com wrote:

Hey @jonjamz! as usual thanks for this package - it's been very useful!

I just updated aldeed:collection2 and it was quite a major update. Part of which involves the removal and deprecation of the aldeed:simple-schema package. Please see below, note from the package author:

Verify that aldeed:simple-schema is not listed in your .meteor/.versions file. If it is, you likely depend on some other package that has an explicit dependency on the Meteor aldeed:simple-schema package. This could cause problems or unexpected behavior. Work with that package author to get an updated version that does not explicitly depend on the aldeed:simple-schema package.

From: https://github.com/aldeed/meteor-collection2

Is it possible to remove the aldeed:simple-schema dependency?

Thanks Daniel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

danielparas commented 7 years ago

Thanks for the quick reply @jonjamz ! If I can help in any way let me know

jonjamz commented 7 years ago

Daniel,

Have you tried using one of the new SimpleSchemas with this package? Curious if it works. I could bump a major version change and switch to the NPM dependency I believe, if there are no compatibility issues.

I had a new version I was working on anyway for a while but I didn't get far enough to publish. Might be a good excuse to jump back in and finish that up as well.

Thanks,

Jon

On Aug 12, 2017, at 1:46 PM, danielparas notifications@github.com wrote:

Thanks for the quick reply @jonjamz ! If I can help in any way let me know

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

danielparas commented 7 years ago

Hey @jonjamz - I never really managed to test it out tbh, as the application I'm using your package on also has another package (tap:i18n) that uses simpleSchema and it's throwing a simpleSchema not found error stopping the app from loading. This is what lead me to research which packages are using simpleSchema. tap:i18n and templates:forms are the only two I'm using and in the case of tap:i18n the issue has already been reported. So i thought might as well give a heads up here also.

Re: testing - Disabling the tap:i18n plugin, to test template:forms with the new simpleschema would cause the application to break, unfortunately. In the mean time I tried setting up a separate test application but I'm having trouble getting templates:forms to work, however I'm not sure if it has anything to do with simpleschema as the error I get is "Cannot set property 'data' of undefined" (the test app is just a copy of the example scripts you have in the package documentation i.e. basicFormBlock + basicinput + associated helpers.)