jonjomckay / fritter

A privacy-friendly Twitter frontend for mobile devices
https://fritter.cc
MIT License
1.4k stars 81 forks source link

[BUG] Media download/save status messages delayed and stacks #623

Open geominorai opened 1 year ago

geominorai commented 1 year ago

Describe the bug

The status bar that appears at the bottom when downloading media does not reflect the actual state of the download progress. Even if the download has already completed, the downloading status still stays up if it has been less for five seconds.

The saved message also stays on for five seconds afterwards, and these stack for each download started in quick succession, so if you started downloads for all four images in an image album post, even if they all finished in under a second, you are stuck with the status messages popping up one after another for 40 seconds straight.

Even worse, they pause if you switch to another app to try waiting it out and resume after you switch back later, all while the actual download already finished so long ago.

To Reproduce

Steps to reproduce the behavior:

  1. Go to image posts or album
  2. Start download for the images in quick succession
  3. (Optionally) Switch away from app and return
  4. See error

Proposed Solution

Moving the download status of each file to Android's notification drawer allows notifications to group themselves in case of multiple files and tapping them opens the actual file. This is the method used by web browsers and some Reddit apps like Sync.

Device Model: Samsung Galaxy S9+ OS: Android 10 Language: English Fritter Version: v3.0.0-beta6+300000772 CI Build: 46aca26