jonjomckay / fritter

A privacy-friendly Twitter frontend for mobile devices
https://fritter.cc
MIT License
1.38k stars 80 forks source link

Fixed and Re-Added Feed, Tweet Search and Hashtag Search #698

Closed ghost closed 1 year ago

ghost commented 1 year ago

I have fixed the Feed, Tweet Searching and Hashtag Searching. These features have been re-added and also fixed my own issue #668, #696 and #695. (As long as twitter don't disable their api again!)

APK File Upload

Github Release Source Code

Igaru22 commented 1 year ago

Thank you this version works great

ghost commented 1 year ago

Good to hear 👍

On Sun, 7 May 2023, 15:09 Igaru22, @.***> wrote:

Thank you this version works great

— Reply to this email directly, view it on GitHub https://github.com/jonjomckay/fritter/pull/698#issuecomment-1537451212, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5PO6LFLFX4FXG23UMQ6HPLXE6UIZANCNFSM6AAAAAAXYK6NVE . You are receiving this because you authored the thread.Message ID: @.***>

ghost commented 1 year ago

Thank you so much for this great update! Fritter without a functioning feed is almost unusable. Don't wanna praise you too soon, but if it keeps working as flawless as it does at the moment, then you're truly a genius in my eyes!

ghost commented 1 year ago

Thank you! 😃

On Sun, 7 May 2023, 16:21 HiFi83, @.***> wrote:

Thank you so much for this great update! Fritter without a functioning feed is almost unusable. Don't wanna praise you too soon, but if it keeps working as flawless as it does at the moment, then you're truly a genius in my eyes!

— Reply to this email directly, view it on GitHub https://github.com/jonjomckay/fritter/pull/698#issuecomment-1537466941, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5PO6LA7JWTO5ZCU4UEVR5LXE64W5ANCNFSM6AAAAAAXYK6NVE . You are receiving this because you authored the thread.Message ID: @.***>

Sponholz commented 1 year ago

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also?

Fix was posted here: #690

ghost commented 1 year ago

Ok, I will do that at some point.

On Sun, 7 May 2023, 17:40 Sponholz, @.***> wrote:

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also?

Fix was posted here: #690 https://github.com/jonjomckay/fritter/pull/690

— Reply to this email directly, view it on GitHub https://github.com/jonjomckay/fritter/pull/698#issuecomment-1537488261, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5PO6LEMPJAJH2YCYP4YA3TXE7F6HANCNFSM6AAAAAAXYK6NVE . You are receiving this because you authored the thread.Message ID: @.***>

Apacelus commented 1 year ago

I cant seem to be able to build this via the GitHub release workflow.

https://github.com/Apacelus/fritter/actions/runs/4908483128/jobs/8764272707

ghost commented 1 year ago

What OS are you using? Windows/Mac/Linux

On Sun, 7 May 2023, 18:50 Apacelus, @.***> wrote:

I cant seem to be able to build this via the GitHub release workflow.

https://github.com/Apacelus/fritter/actions/runs/4908483128/jobs/8764272707

— Reply to this email directly, view it on GitHub https://github.com/jonjomckay/fritter/pull/698#issuecomment-1537503308, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5PO6LE3TTNHMLHCJT7MR2LXE7OHNANCNFSM6AAAAAAXYK6NVE . You are receiving this because you authored the thread.Message ID: @.***>

Apacelus commented 1 year ago

What OS are you using? Windows/Mac/Linux On Sun, 7 May 2023, 18:50 Apacelus, @.> wrote: I cant seem to be able to build this via the GitHub release workflow. https://github.com/Apacelus/fritter/actions/runs/4908483128/jobs/8764272707 — Reply to this email directly, view it on GitHub <#698 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5PO6LE3TTNHMLHCJT7MR2LXE7OHNANCNFSM6AAAAAAXYK6NVE . You are receiving this because you authored the thread.Message ID: @.>

Im using github workflows... I linked the run in my previous comment. The run uses ubuntu-latest, so that would be ubuntu 22.04: https://github.com/Apacelus/fritter/actions/runs/4908483128/workflow#L11

ghost commented 1 year ago

run

You cannot use github actions to build the app you have to use android studio!

ghost commented 1 year ago

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also?

Fix was posted here: #690

I have now merged the pull request into my fork: Github Release

Apacelus commented 1 year ago

run

You cannot use github actions to build the app you have to use android studio!

The original project certainly used github actions to build their releases, so it is possible.

ghost commented 1 year ago

I will look into it

Sponholz commented 1 year ago

Thanks, this version works awesomely, can you please try to implement the fix to expanding tweets with more than 10 comments also? Fix was posted here: #690

I have now merged the pull request into my fork: Github Release

Thanks! Using it at the moment, really appreciate the time doing all the fixes.

Cheers!

jonjomckay commented 1 year ago

@TheHCJ thank you for putting in the effort to patch this - I really appreciate the support, but I won't be adding the feed back into Fritter. Please see my comment on issue #668.

jaum20 commented 1 year ago

I am late for the party. Repo deleted 🥲

Sponholz commented 1 year ago

I am late for the party. Repo deleted 🥲

Check TheHCJ git page, he has now a fork of fritter with the feed.

I totally understand and respect Jonjomckay decision, but it's also nice to have an option with the feed included.