jonjomckay / quahog

A PHP client library for the ClamAV clamd daemon
MIT License
80 stars 23 forks source link

Changed "private" methods and properties to "protected" #9

Closed TheOnlyMerlin closed 8 years ago

TheOnlyMerlin commented 8 years ago

What Was Changed

$socket property and all private methods on the class were changed to protected.

Why it Was Changed

TLDR: We needed access to private stuff

We are using this library for a proprietary project, and we needed to extend functionality of the class, which required access to the socket object. Unfortunately this object was marked as private, so we had to fork the code instead. To avoid the necessity for ourselves and others in the future, we changed some visibility levels.