Fix the examples - Githubissues

jonkemp / gulp-useref

Parse build blocks in HTML files to replace references to non-optimized scripts or stylesheets.

MIT License

705 stars 93 forks source link

Fix the examples #150

Closed tkrotoff closed 8 years ago

tkrotoff commented 8 years ago

add gulp.task(...) when missing
useref({}, lazypipe().pipe(...)) should be useref({}, lazypipe().pipe(...)()) (see lazypipe example here)
gulp.dest(dist) should be gulp.dest('dist')
add missing var ts = require('gulp-typescript');

(I've detected these mistakes while updating gulp-useref TypeScript definition: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/6864)

jonkemp commented 8 years ago

Thanks!

tkrotoff commented 8 years ago

@jonkemp btw, option noconcat feels awkward, shouldn't it be noConcat? like searchPath, noAssets...

jonkemp commented 8 years ago

I do not lay awake at night thinking about things like this. But yes I do agree with you that it should be consistent. Although, just changing the spelling would be a breaking change requiring an entirely new version as it would not be backwards compatible. My suggestion would be rewriting it so that they would both work, which shouldn't be difficult. Please create a separate issue for this if you want it changed.