jonkemp / gulp-useref

Parse build blocks in HTML files to replace references to non-optimized scripts or stylesheets.

MIT License

705 stars 93 forks source link

Migration Notes v2->v3 #154

Closed rwillmer closed 8 years ago

rwillmer commented 8 years ago

153

jonkemp commented 8 years ago

Looks pretty good. I just have two requests. First, please add code formatting to the error examples to make them more readable. Second, if you like, I would be willing to move this section up above the Options section. It's pretty relevant and someone scanning the docs could find it faster higher up. It's also more related to the Usage section.

rwillmer commented 8 years ago

How about this? I'd prefer to leave the migration section at the end, because over time, it will become less relevant. But I've added a mention of the errors and that section at the top.

jonkemp commented 8 years ago

Please squash the commits and I'll accept this change. Thanks!

rwillmer commented 8 years ago

Squashed. I think. (Haven't done this before so let me know if I need to do something else)