jonkemp / gulp-useref

Parse build blocks in HTML files to replace references to non-optimized scripts or stylesheets.

MIT License

705 stars 93 forks source link

How to use the newLine option based on the file type? #241

Closed phtwo closed 6 years ago

phtwo commented 7 years ago

ep: ';' it work in js , but cannot be used for css files

jonkemp commented 7 years ago

It takes a string, but I'm not sure what will work for CSS files. I didn't know that was an issue.

phtwo commented 7 years ago

@jonkemp yes JS files use ';' and skip CSS files. This is what I want.

jonkemp commented 7 years ago

Ah I see.

jonkemp commented 6 years ago

There are currently 2 pull requests open that would meet the requirements here. Mine basically just meets the requirements of "js files get the newline and CSS files do not".

249

The other one uses options to let you specify which file extensions get skipped.

248

Can we get some feedback on these? I think my change is fine but I don't want to break everybody's builds since the option has been there a long time.

jonkemp commented 6 years ago

Fixed here https://github.com/jonkemp/gulp-useref/pull/249.

jonkemp commented 6 years ago

Thanks to @lfurzewaddock for much help in closing this.