search

jonkemp / inline-css

Inline css into an html file.
MIT License
429 stars 84 forks source link

Chore: Bump cheerio from 0.22.0 to 1.0.0-rc.10 #114

Closed Yaminyam closed 2 years ago

Yaminyam commented 2 years ago

111 There was an nth-check security issue in cheerio > css-select > nth-check dependency, so cheerio version was updated

derekbwarren commented 2 years ago

Is it possible for this PR to get merged to resolve this issue?

jonkemp commented 2 years ago

I wonder why the tests didn't run. I would need to verify that first.

Yaminyam commented 2 years ago

I wonder why the tests didn't run. I would need to verify that first.

Merge from forked repositories does not have permission for action

pleymor commented 2 years ago

Hi! I tried to fix them in another PR: https://github.com/jonkemp/inline-css/pull/115

jonkemp commented 2 years ago

Tests are failing.

pleymor commented 2 years ago

All tests were successful when I launched npm run test. Which one did u see failing please?

jonkemp commented 2 years ago

@pleymor this is not your pr but I did leave feedback on yours too. Can you address that?