search

jonkemp / inline-css

Inline css into an html file.
MIT License
429 stars 84 forks source link

Downgrade bluebird to prevent bug in Firefox #90

Closed DanielRuf closed 4 years ago

DanielRuf commented 4 years ago

See https://github.com/petkaantonov/bluebird/issues/1623

We should pin dependencies in general. In this case 3.5.5.

jonkemp commented 4 years ago

We actually don't even need it now that Node has native support for Promises. I ran it without using Bluebird and all the tests pass.

jonkemp commented 4 years ago

I'll make a PR and you can test if you want.

jonkemp commented 4 years ago

The PR is open. You can test it by including it in your dependencies like this: "inline-css": "jonkemp/inline-css#remove-bluebird".