fix css rel disscussion

jonkemp / useref

Parse build blocks in HTML files to replace references

MIT License

51 stars 13 forks source link

fix css rel disscussion #15

Closed webyom closed 7 years ago

webyom commented 7 years ago

If user defined rel attribute such as preload, we should remove the default stylesheet rel.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.254% when pulling cc530be014de56aa12183de8bf19f313bec62d1a on webyom:fix-rel into ce1d51ff2c5f7ee2e2f693e2e2336fa42df1e6e7 on jonkemp:master.

jonkemp commented 7 years ago

@webyom can you explain the problem more?

webyom commented 7 years ago

@jonkemp currently stylesheet is hardcoded for rel attribute. But rel has other potential values such as preload. If user defined rel attribute, there will be two rel attributes in the link tag.

jonkemp commented 7 years ago

@webyom what do you think about adding some documentation for this?

webyom commented 7 years ago

@jonkemp I have updated document for this pr, please review it.

coveralls commented 7 years ago

Coverage increased (+0.02%) to 99.254% when pulling 59322af2cb424585df2e784b42f67572abe737c5 on webyom:fix-rel into ce1d51ff2c5f7ee2e2f693e2e2336fa42df1e6e7 on jonkemp:master.

jonkemp commented 7 years ago

Ok. Go ahead and squash the commits and I'll merge. Thanks!

webyom commented 7 years ago

@jonkemp please do it in pr #16, I will close this pr.

jonkemp commented 7 years ago

Not sure why the need for a new PR. I just realized you can squash commits now when a pull request is merged so that was not necessary. If you are interested to know about squashing commits in git, this is a good tutorial on it.

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

webyom commented 7 years ago

@jonkemp I have squashed the commits in my local repository, but it shown nothing to push to origin. So I merged it to my master branch with squash option and opened another pr. I will read the article to see if I missed something. Thanks.