search

jonkogan / nullpomino

Automatically exported from code.google.com/p/nullpomino
0 stars 0 forks source link

broadcastRoomInfoUpdate not called on spectator leave #18

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. join room
2. sit out
3. leave

What is the expected output? What do you see instead?
number of spectators is not update in room list

there is something wrong with this loop:
for(NetRoomInfo roomInfo: deleteList)

should we add broadcastRoomInfoUpdate(roomInfo) at end of statement of 
if(!deleteRoom(roomInfo))?

Original issue reported on code.google.com by w.kowa...@gmail.com on 11 Aug 2010 at 11:41

GoogleCodeExporter commented 8 years ago 
of course i mean

there is something wrong with statement if(!deleteRoom(...)) {...}, we have 3 
of those.

Original comment by w.kowa...@gmail.com on 11 Aug 2010 at 11:54

GoogleCodeExporter commented 8 years ago 
Looks like this bug is not present anymore in latest svn. (I tested in r511)
Most likely the changes made from "View lobby while in room" feature fixed this 
bug.

Original comment by pbomqlu910963@gmail.com on 26 Oct 2010 at 2:00