jonkogan / nullpomino

Automatically exported from code.google.com/p/nullpomino
0 stars 0 forks source link

loginfail message is never send, because close is called #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. connect to wrong version server

What is the expected output? What do you see instead?
wrong version message won't show up on client.

Because nullpomino networking works in non blocking mode calling close will 
cancel all pending sends. I have no idea what would be best way to fix it.

Original issue reported on code.google.com by w.kowa...@gmail.com on 11 Aug 2010 at 4:05

GoogleCodeExporter commented 8 years ago
I can't reproduce this. When I try to connect to the harddrop.com netserver 
using the latest version, it gives me this:

*** Connected to harddrop.com:9200
*** Server version:7.3
*** Number of players:8
*** LOGIN FAILED! Reason:DIFFERENT_VERSION 7.3 

Original comment by Zirc...@gmail.com on 20 Aug 2010 at 2:39

GoogleCodeExporter commented 8 years ago
maybe nullnoname fixed it already? there is no problem with lastest svn 
version, but i don't see what was changed. you can check 7.3 version to see 
what i mean.

Original comment by w.kowa...@gmail.com on 20 Aug 2010 at 11:04

GoogleCodeExporter commented 8 years ago
@Comment 2  by w.kowaluk, Aug 20
No, I'm not doing anything to this bug yet. This bug still exists, but 
sometimes it doesn't happen at all.
Maybe we should check the server version from the client?
If the version is different, it disconnects from client side, then displays an 
error message.

Original comment by pbomqlu910963@gmail.com on 22 Aug 2010 at 2:24

GoogleCodeExporter commented 8 years ago
I changed the logic of login fail message in r529, so it is always sent now (at 
least in my local server).
But I haven't verified it with a remote server yet. :p

Original comment by pbomqlu910963@gmail.com on 6 Nov 2010 at 2:38

GoogleCodeExporter commented 8 years ago

Original comment by w.kowa...@gmail.com on 16 Jan 2011 at 4:05