search

jonlb / node-build

NO LONGER MAINTAINED - an ant-type build system for node w/predefined tasks and the ability to add tasks at any time.
MIT License
13 stars 2 forks source link

Remove dependency on Wrench npm package (it is deprecated) #4

Open pulekies opened 7 years ago

pulekies commented 7 years ago

What did you expect to happen? Installing 'node-build' via npm should succeed with no warnings.

What actually happens Installing 'node-build' via npm gives the following warning: npm WARN deprecated wrench@1.3.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for.

How to reproduce Run an npm install for 'node-build': npm install build

graingert commented 7 years ago

@pulekies I'm presuming you found this via Sinon: https://github.com/sinonjs/sinon/commit/37ff38b7369c569501bb94e684eac6f5db7bd556

build was included by accident.

pulekies commented 7 years ago

Yes, thanks for responding. It was suspicious to me that it was included, but I figured I might as well log this issue anyway.

graingert commented 7 years ago

@jonlb it might be worth issuing:

npm run deprecate build "did you mean 'npm run build'?"
trollepierre commented 7 years ago

wrench is deprecated... npm WARN deprecated wrench@1.3.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.