search

jonleighton / focused_controller

MIT License
468 stars 27 forks source link

Fix tests & upgrade development dependencies #29

Closed beedub closed 11 years ago

beedub commented 11 years ago

An acceptance test was failing because Rails was not defined, and another because of https://github.com/jonleighton/poltergeist/issues/320.

The spec suite now passes, but in some cases the server is not shut down automatically, which requires manual cleanup.

https://github.com/jonleighton/focused_controller/issues/27

jonleighton commented 11 years ago

Damn, I'm sorry I didn't see this today - I actually spent some time fixing up the test suite myself earlier as I thought I was going to fix something else, which I then didn't actually need to. Sorry to have wasted your time. As a sidenote, I found a different solution for the Rails not defined issue, as we don't actually want the isolated test helper to have to depend on Rails.

beedub commented 11 years ago

No worries. Curious to see your solution.

jonleighton commented 11 years ago

It's committed and pushed :)