search

jonlives / knife-spork

A workflow plugin to help many devs work with cookbooks and environments at once
Other
335 stars 97 forks source link

pass whole config, not just cookbook_path #149

Closed jordane closed 10 years ago

jordane commented 10 years ago

This was causing an issue (#140) because we were passing an Array instead of a Hash, and CookbookUploader no longer accepts a path argument.

Compare the two following links:

https://github.com/opscode/chef/blob/11.14.6/lib/chef/cookbook_uploader.rb#L39 https://github.com/opscode/chef/blob/12.0.0.alpha.1/lib/chef/cookbook_uploader.rb#L38

jordane commented 10 years ago

@lamont-granquist cool, thanks for the tip.

jonlives commented 10 years ago

@jordane apologies for taking a while to get to this, busy time of year at Etsy towers. Hoping to get to the next release in the next couple of weeks!

lamont-granquist commented 10 years ago

We ran into this with chefspec as well, and we're probably going to wind up checking the arity of the method rather than inspecting the chef version. That might be cleaner, although it looks like you've already worked around the prereleases problem.