jonlives / knife-spork

A workflow plugin to help many devs work with cookbooks and environments at once
Other
335 stars 97 forks source link

Fix for when custom_path is not defined. on Windows this was causing th... #150

Closed carpnick closed 10 years ago

carpnick commented 10 years ago

...e cookbook to not be bumped correctly, and was failing without an exception

Sample output pre change: C:\code\Internal\cookbooks\eis\sys_win_base>knife spork bump sys_win_base -o "./../" exit I ran

Post Change: C:\code\Internal\cookbooks\eis\sys_win_base>knife spork bump sys_win_base -o "./../" Successfully bumped sys_win_base to v0.2.5!

adamedx commented 10 years ago

@jonlives, thoughts? I'm new to knife-spork, but looks like this PR would unblock use of the gem on Windows.

jonlives commented 10 years ago

Added this to the next release milestone :)

adamedx commented 10 years ago

:boom: -- awesome!