jonlives / knife-spork

A workflow plugin to help many devs work with cookbooks and environments at once
Other
335 stars 97 forks source link

Interesting error when coming across 'omni' with an unknown cookbook #181

Closed essjayhch closed 9 years ago

essjayhch commented 9 years ago

Issue

When carrying out routing operation of the omni command I saw this:

knife spork omni --remote --environment testing precona
~/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/chef-12.0.3/lib/chef
OMNI: Bumping precona
ERROR: TypeError: no implicit conversion of nil into String

Turns out I had typo'd precona rather than percona (shock horror). Not sure exactly where the bug will be But I'm guessing that it will be somewhere around the conversion of the args into an object somewhere not detecting that the precona cookbook doesn't exist.

mrtazz commented 9 years ago

I'll look into this. Seems like we should just error with something along the lines of "No cookbook name 'precona' found"

mrtazz commented 9 years ago

@essjayhch which version of knife-spork are you running? I'm unable to reproduce this error, getting a proper error message about the cookbook not existing:

% knife spork omni --remote --environment testing precona
OMNI: Bumping precona
ERROR: Chef::Exceptions::CookbookNotFound: Could not find cookbook 'precona' in any of the sources!
essjayhch commented 9 years ago

turns out i was running 1.5.0. I've Updated to 1.5.1, however still having the same result. I have manually removed 1.5.0 as well just to confirm. I'm assuming there isn't anything config wise that could cause this...

mrtazz commented 9 years ago

@essjayhch hmm ok. Can you rerun the command with -VV and paste the output and also the configuration you are using? It could be that it's one of the plugins interfering here.

mrtazz commented 9 years ago

@essjayhch any update on this?

mrtazz commented 9 years ago

closing this for lack of activity/updates. However please don't hesitate to reopen if the issue persists or there is new information that helps to debug this.