search

jonls / redshift

Redshift adjusts the color temperature of your screen according to your surroundings. This may help your eyes hurt less if you are working in front of the screen at night.
http://jonls.dk/redshift
GNU General Public License v3.0
5.92k stars 429 forks source link

Redshift is setting brightness relative to what was already set #670

Open jvalrog opened 6 years ago

jvalrog commented 6 years ago

Describe the bug I start lightdm with a brightness setting of 0.60 because I can turn on my computer in the middle of the night and I don't want to get flashed in the eyes.

So, after that, I login and redshift starts fading. The problem is it's not taking into account that brightness is actually at 0.60 and will decrease it to 0.40 for example even though I have 0.60 as my night setting. That's just wrong IMO.

It should take into account that it's already at my night setting, for example, and do nothing at all.

Is it a bug or a design desicion? Is there a way for redshift to always start at a certain brightness setting? Starting from 100% brightness is bad at night, but starting at 50% is good both in day and night. It would be sane to start fading from night setting the first time it's executed.

Software versions (please complete the following information):

jonls commented 6 years ago

Can you please clarify what you are doing?

I start lightdm with a brightness of 0.60

What does this mean? Is it a setting in lightdm? I'm not familiar with lightdm so please explain or point to documentation. Is lightdm also adjusting the gamma ramps?

It sounds like maybe you need the -P option which will let Redshift reset the gamma ramps before starting.

CedricReichenbach commented 5 years ago

For what it's worth, I ran into the issue that redshift suddenly started applying brightness values in a relative manner, i.e. redshift -O 6500 -b 0.8 would reduce brightness by 20% rather than setting it to an absolute 80%, and increasing wasn't possible that way. Using -P in addition makes it work as expected again.

ilgare commented 4 years ago

I am using redshift-1.12, with redshift-gtk autostarted at session startup. I am using XFCE and there is no other software interfering with the display settings. The method configured in redshift.conf is randr. Each time I log out and then log back in, at startup redshift adjusts the colors relative to the current (hence, already adjusted) values. So with each login I get a screen darker and more red. To reset things, I have to terminate the app, and do redshift -O 6500 -P on the command line.

Could we make the application behave as if the flag -P was set all the time, so that at every login the adjustmens are made relative to absolute values? That was my impression from the comments in the changelog of release 1.12 but maybe I misunderstood something.