search

jonls / redshift

Redshift adjusts the color temperature of your screen according to your surroundings. This may help your eyes hurt less if you are working in front of the screen at night.
http://jonls.dk/redshift
GNU General Public License v3.0
5.82k stars 425 forks source link

wrong path for .conf in README #845

Open hobisi2781 opened 2 years ago

hobisi2781 commented 2 years ago

Describe the bug readme lists the path to place the redshift.conf file as ~/.config/redshift/redshift.conf in case XDG_CONFIG_HOME is not defined. The path should actually be ~/.config/redshift.conf.

To Reproduce

  1. Go to ~/.config/redshift/ and place the redshift.conf. It won't get applied.

Expected behavior The configuration should get applied as written in readme

Error output/logs/screenshots

Software versions (please complete the following information):

yannickperrenet commented 2 years ago

The reason that ~/.config/redshift/redshift.conf is not being applied is most likely caused by: https://github.com/jonls/redshift/issues/672 (since you are on Debian).

Redshift will then fall back to the legacy path ~/.config/redshif.conf for backward compatibility. Therefore it seems like ~/.config/redshif.conf should be put in the README, whilst actually ~/.config/redshift/redshift.conf is indeed the correct path.

Hope that helps.

RafalSkolasinski commented 2 years ago

For me it fails on both config locations

$ redshift -c ~/.config/redshift/redshift.conf
fopen: Permission denied
Unable to load config file.

as well as

redshift -c ~/.config/redshift.conf
fopen: Permission denied
Unable to load config file.
thegrojas commented 1 year ago

For me it fails on both config locations

$ redshift -c ~/.config/redshift/redshift.conf
fopen: Permission denied
Unable to load config file.

as well as

redshift -c ~/.config/redshift.conf
fopen: Permission denied
Unable to load config file.

Same for me

Linux 5.10.0-15-amd64 #1 SMP Debian 5.10.120-1 (2022-06-09) x86_64 GNU/Linux

yannickperrenet commented 1 year ago

Maybe https://github.com/jonls/redshift/issues/850#issuecomment-1193378198 helps. You can check whether it is indeed AppArmor that prevents redshift reading the configuration files.

crypdick commented 3 months ago

I just encountered this problem on Ubuntu 23.10 after following the README. I figured out to move the conf to ~/.config by reading man redshift.

I think that A) the manpages and README should have consistent instructions, and B) regardless of which is the "right" path, this gotcha should be documented in both since it is clearly affecting many users.