search

jonluca / vite-typescript-ssr-react

🚀 A Vite Typescript SSR React boilerplate!
https://blog.jonlu.ca/posts/vite
342 stars 48 forks source link

Test support #3

Closed Laishuxin closed 2 years ago

Laishuxin commented 2 years ago

This repo is great but doesn't support testing. I just make it support testing by using jest and adding some basic test cases. Meanwhile, I got an error when I run yarn dev. So I modify the dev script a little.

jonluca commented 2 years ago

looks good to me!

jonluca commented 2 years ago

Looks like theres an issue with the node version

error eslint-plugin-jest@25.2.2: The engine "node" is incompatible with this module. Expected version "^12.13.0 || ^14.15.0 || >=16.0.0". Got "15.14.0"

can we bump the pinned node version to 16?

Laishuxin commented 2 years ago

Looks like theres an issue with the node version

error eslint-plugin-jest@25.2.2: The engine "node" is incompatible with this module. Expected version "^12.13.0 || ^14.15.0 || >=16.0.0". Got "15.14.0"

can we bump the pinned node version to 16?

Sorry, I forgot to think about this situation. I'll try to fix this issue.