search

jonm / SillyMUD

SillyMUD, a derivative of DikuMud
Other
8 stars 5 forks source link

Read object error checking #86

Closed dangitall closed 8 years ago

jonm commented 8 years ago

Gotta run someone to swim team practice, will resume review upon return. :)

jonm commented 8 years ago

Ok, last comment would be: instead of (or perhaps in addition to) telling the player there was an error and they should file a bug, perhaps use log_msgf too?

dangitall commented 8 years ago

Do you mean for the NULL checks? I avoided this mostly because log messages will be generated internally by the read_mobile and read_object functions themselves with more precise info (the fp position). But if you think it would be more useful to have context (or there is some other place that an error slipped through unlogged), lmk!

jonm commented 8 years ago

Ah, ok, no if a log message gets generated elsewhere, then I am :+1:​