search

jonmatifa / zfsmanager

ZFS administration tool for Webmin
Other
108 stars 22 forks source link

Cosmetic bug in gpt/name Fix. #27

Open JRGTH opened 6 years ago

JRGTH commented 6 years ago

Hello, Thanks for this really great project, a definitive must have tool for Webmin nowadays, working so far so good in FreeBSD 11.1 + Webmin 1.881 + Authentic Theme 19.09.2, I use it for monitoring purposes mostly since very simple and sleek looking at.

Found a little cosmetic bug that was changing my GPT/LABEL devices to "|_gpt/hdd-XXXX" instead "gpt/hdd-XXXX", I found on line #31 on "status.cgi" it was causing this issue, seems that removing the "|_" characters in that line fixed the cosmetic "gpt/name" bug instantly, otherwise thanks again for bring this really needed feature to Webmin.

Regards

hjmallon commented 6 years ago

I think this is trying to indicate the structure of the VDevs. The bigger issue is that multiple vdevs in a zpool do not look correct. Maybe the children structure could be inidcated with tabs or layout changes?

JRGTH commented 6 years ago

Hello thanks for the input, maybe since I'm using the module under FreeBSD I haven't noticed any issues with multi-vdev look, except for the aforementioned characters addition, though I could perform more testing under a VM in this regards just to be sure.