search

jonmbake / discourse-ldap-auth

Discourse plugin to enable LDAP/Active Directory authentication.
MIT License
70 stars 53 forks source link

Fixes #66 - Update omit_username -> override_username following core changes #67

Closed davidtaylorhq closed 2 years ago

davidtaylorhq commented 2 years ago

This commit maintains backwards compatibility with older Discourse changes

jonmbake commented 2 years ago

Thanks for submitting this PR, @davidtaylorhq! I appreciate it.

JimboJoe commented 2 years ago

Hi, looks like we need a formal release of this fix with latest 2.8.7 version of Discourse (see here for the corresponding issue in the YunoHost package). Are you planning to do a release any time soon?

jonmbake commented 2 years ago

@JimboJoe Discourse should pull in the most recent version of this plugin w/o having to bump the plugin release version. We can bump the version today, but it shouldn't be necessary to get this change. Are you sure the issue is related to this?

JimboJoe commented 2 years ago

I've tested with the latest version of your (great!) plugin and it fixes the problem (we actually upgraded our YunoHost package from 2.7 to 2.8)! We can't upgrade "simply" this plugin as it is automatically installed during the YunoHost package installation (with LDAP auto-configuration for YunoHost), and this installation mode without git prevents upgrade. And our current issue is quite critical as people (and in particular admins!) can't currently access the forum... 😅 Thanks in advance!

jonmbake commented 2 years ago

OK, @JimboJoe . Version 0.6.0 has been released: https://github.com/jonmbake/discourse-ldap-auth/releases/tag/v0.6.0.

JimboJoe commented 2 years ago

Thanks a lot!! :+1: