search

jonmbake / react-terminal-ui

A terminal react component with support for light and dark modes.
https://jonmbake.github.io/react-terminal-ui/demo/
MIT License
205 stars 30 forks source link

Scrolldown Click Event #14

Closed SorrisoPraFoto closed 3 years ago

SorrisoPraFoto commented 3 years ago

Hi,

Continuing my suggestion from the issue #12 , the scrolldown event on is triggered onClick when the pages has a height more than 100vh.

I made a video showing this using the demo terminal, I putted a div element test before the terminal and increased the height of the body, making a bigger site, and you will see the scrolldown animation to the final line in the terminal, thats what I suggest to remove, soo the dev's can implement it manually and optionally.

https://user-images.githubusercontent.com/14830148/121018958-5b317100-c775-11eb-963a-a52aafedcc6b.mp4

jonmbake commented 3 years ago

@SorrisoPraFoto A fix was pushed for this issue. Can you try out v0.1.13 and confirm that it is fixed?

SorrisoPraFoto commented 3 years ago

It's Working!

Thank u soo much for that, for real.