search

jonmbake / react-terminal-ui

A terminal react component with support for light and dark modes.
https://jonmbake.github.io/react-terminal-ui/demo/
MIT License
205 stars 30 forks source link

Remove id attributes from cursor and hidden input elements #39

Closed jonmbake closed 1 year ago

jonmbake commented 1 year ago

Describe the bug In PR #37, we added an id attribute in order to be able to reference cursor and hidden input elements. This breaks when multiple terminal are rendered to the page.

To Reproduce Render multiple terminals to the the page; things are broken.

Expected behavior Support rendering multiple terminals to the pages.

Screenshots N/A

Additional context See discussion here: https://github.com/jonmbake/react-terminal-ui/pull/37/files#r1183577988

jonmbake commented 1 year ago

@jerwolff FYI: I created this issue that we talked about.

jonmbake commented 1 year ago

Fixed by PR #40 .